Enable SwiftLint rule: flatmap_over_map_reduce#25529
Merged
Conversation
Contributor
|
| App Name | WordPress | |
| Configuration | Release-Alpha | |
| Build Number | 32157 | |
| Version | PR #25529 | |
| Bundle ID | org.wordpress.alpha | |
| Commit | 63df54e | |
| Installation URL | 61ug1gm5cruu8 |
Contributor
|
| App Name | Jetpack | |
| Configuration | Release-Alpha | |
| Build Number | 32157 | |
| Version | PR #25529 | |
| Bundle ID | com.jetpack.alpha | |
| Commit | 63df54e | |
| Installation URL | 1t7p91ma5qs0o |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR enables SwiftLint’s flatmap_over_map_reduce rule and updates the one in-repo occurrence to match the preferred flattening pattern, avoiding the intermediate array-of-arrays allocation.
Changes:
- Enabled the
flatmap_over_map_reducerule in.swiftlint.yml. - Replaced
map { ... }.reduce([], +)withflatMap { ... }inGutenbergFilesAppMediaSource.getDocumentTypes(...).
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| WordPress/Classes/ViewRelated/Gutenberg/Utils/GutenbergFilesAppMediaSource.swift | Updates array-flattening implementation to use flatMap per new SwiftLint rule. |
| .swiftlint.yml | Adds flatmap_over_map_reduce to the opt-in only_rules list. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
crazytonyli
approved these changes
May 6, 2026
Adds the rule to `only_rules`. The rule prefers `flatMap { ... }`
over `map { ... }.reduce([], +)` for flattening nested arrays —
this avoids materialising an intermediate array of arrays.
Part of the Orchard SwiftLint rollout campaign.
---
Generated with the help of Claude Code, https://claude.ai/code
Co-Authored-By: Claude Code Opus 4.7 <noreply@anthropic.com>
mokagio
force-pushed
the
mokagio/swiftlint-flatmap-over-map-reduce
branch
from
21dcf30 to
63df54e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Enables SwiftLint's
flatmap_over_map_reducerule.The rule prefers
flatMap { ... }overmap { ... }.reduce([], +)for flattening nested arrays — this avoids materialising an intermediate array of arrays.Part of the Orchard SwiftLint rollout campaign.
Test plan
swiftlint lint --strict --no-cacheis clean against the rule.🤖 Generated with Claude Code